[ovs-dev] [PATCH v4] datapath-windows: netdev-windows fixes for vswitchd bringup.

Ben Pfaff blp at nicira.com
Thu Oct 16 00:08:08 UTC 2014


On Wed, Oct 15, 2014 at 04:13:10PM -0700, Ankur Sharma wrote:
> Added the handlers for update_flags and set_etheraddr.
> These handlers were needed for vswitchd bringup on windows
> platform.
> 
> Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
> Acked-by: Nithin Raju <nithin at vmware.com>

I don't understand why the flags code in this patch translates
NETDEV_* to and from another format.  The Linux version does it
because the kernel uses a different format, but this code is just a
dummy so there's no need to do that.

I don't understand why this code only allows
netdev_windows_set_etheraddr() to set an Ethernet address if one is
already cached.

Thanks,

Ben.



More information about the dev mailing list