[ovs-dev] [PATCH] lib/dpif: Fix crash in format_odp_actions, actions = 0x0

Ben Pfaff blp at nicira.com
Sat Oct 18 16:34:28 UTC 2014


On Fri, Oct 17, 2014 at 06:20:57PM -0700, Madhu Challa wrote:
> I think I know whats happening. In case there is an error getting the
> datapath flow we should not try logging it since the flow is not valid.
> 
> dpif_netlink_operate__
> {
> ...
>         case DPIF_OP_FLOW_GET:
>                 op->error = dpif_netlink_flow_from_ofpbuf(&reply,
> txn->reply);
>                 if (!op->error) {
>                     dpif_netlink_flow_to_dpif_flow(get->flow, &reply);
>                 }

Isn't that what I said before?  I agree, obviously.



More information about the dev mailing list