[ovs-dev] [PATCH 3/4] datapath-windows: Fixes in packet created for userspace

Nithin Raju nithin at vmware.com
Sat Oct 18 18:31:30 UTC 2014


> +
> +    nlMsg = (PNL_MSG_HDR)NlBufAt(&nlBuf, 0, 0);
> +    nlMsg->nlmsgLen = NlBufSize(&nlBuf);
> 
> [ANKUR]: Should we not align the msgLen here.?

Each of the attributes written out to the nlBuf are already aligned. If you look at the nlAttrLen of each attribute, it is not set to the aligned size, but the nlBuf->tail would have got moved to account for alignment, and thereby NlBufSize() gives the correct value.

This is my understanding. Pls. correct me if this is wrong.

thanks,
-- Nithin



More information about the dev mailing list