[ovs-dev] [PATCH] bridge: Store datapath version into ovsdb

[Justin Pettit]

> On Oct 22, 2014, at 2:18 PM, Andy Zhou <azhou at nicira.com> wrote:

In addition to what Ben said, here are a few other things.

> +    /* Set true when created. Reset to false after the datpath

Datapath is mispelled.

> +static void
> +init_ovs_version(const char *version)
> +{
> +    if (ovs_version) {
> +        free_ovs_version();
> +    }
> +
> +    ovs_version = xstrdup(version ? version : VERSION);

In the case of the built-in kernel module, isn't this going to return VERSION which is the OVS version number?

> +    /* For "system" type datapath, record the Linux kenrel modules'
> +     * verions number. Other datapath types are assumed to be supplied
> +     * by openvswitch itself, thus inherit the same version string. */

Kernel is misspelled.

> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> index d90f221..0af0637 100644
> --- a/vswitchd/vswitch.xml
> +++ b/vswitchd/vswitch.xml
> @@ -582,6 +582,11 @@
>         column="other-config" key="datapath-id"/> instead.)
>       </column>
> 
> +      <column name="datapath_version">
> +        Reports the OpenFlow datapath version in use.  Can be empty if
> +        datapath version can not be determined.
> +      </column>

I believe this should be "Open vSwitch" and not "OpenFlow".

--Justin