[ovs-dev] [PATCH 5/5] lib/dpif-netlink.c: add support for packet receive on Windows

Nithin Raju nithin at vmware.com
Wed Oct 22 22:11:01 UTC 2014


On Oct 22, 2014, at 3:07 PM, Eitan Eliahu <eliahue at vmware.com>
 wrote:

>> ovs_assert(index <= VPORT_SOCK_POOL_SIZE);
>   index = (index == VPORT_SOCK_POOL_SIZE - 1) ? 0 : index + 1;
> 
> I think that index should never be greater than ( VPORT_SOCK_POOL_SIZE - 1) if I understand the logic here.

Got it. There's one more sort of bug where we'd start with the second sockets always when the number of sockets > 1.

I'll fix this in the v2. Thanks for the review.

-- Nithin




More information about the dev mailing list