[ovs-dev] [PATCH] Build: shared libraries and versioning

[Gurucharan Shetty]

>
> The reason that it bothers me is that, if I recall correctly, turning
> on building shared libraries actually causes every source file to be
> built twice, roughly doubling compile time.  That's not a big deal
> when building for a distribution, etc., but it slows the dev cycle,
> which is a big deal for me.  I guess I could always provide the right
> "configure" flag to disable shared libraries, and maybe I should; I
> don't know what is considered "best practice".
The default will likely fail on Windows platform.


>
> Here's a couple of examples of the kind of thing that causes a crash
> on Mac OS X, from a different project that I also contribute to:
> http://git.savannah.gnu.org/cgit/pspp.git/commit/?id=d32245378988468e419654b9fe06fef066adfda1
> http://git.savannah.gnu.org/cgit/pspp.git/commit/?id=4afd608d61b469b07f6c149e87ba25fabef9909e
>
> I seem to recall that there was a related bug a while back when we
> added the existing shared library support.  I spent some time looking
> through the mailing list and the Git history, though, and I couldn't
> find it.
Do you mean this one?
commit 6a92c6f079f7f19c6a46d167af16ff600d3023d0
Author: Gurucharan Shetty <gshetty at nicira.com>
Date:   Thu Jul 17 18:15:17 2014 -0700

    ovsdb: Don't add ovsdb-server.c to libovsdb.

    Without this change, with shared libraries, VLOG
    constructor for ovsdb-server would get called twice corrupting
    the 'vlog_modules' list causing an infinite loop.

    Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
    Reported-by: Gur Stavi <gstavi at mrv.com>
    Acked-by: Ben Pfaff <blp at nicira.com


> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev