[ovs-dev] [dp version v3] bridge: Store datapath version into ovsdb
Andy Zhou
azhou at nicira.com
Thu Oct 23 20:06:14 UTC 2014
Thanks for the clarification. Just posted v4 with the fix suggested.
On Thu, Oct 23, 2014 at 11:49 AM, Justin Pettit <jpettit at nicira.com> wrote:
>
>> On Oct 23, 2014, at 11:36 AM, Andy Zhou <azhou at nicira.com> wrote:
>>
>>> On Thu, Oct 23, 2014 at 11:27 AM, Justin Pettit <jpettit at nicira.com> wrote:
>>> This isn't a full review, but I just wanted to point out again about the documentation string and I noticed a small typo in a comment.
>>>
>>>> + /* Get datapath version. Caller is responsible for free the string
>>>> + * returned. */
>>>
>>> s/free/freeing/
>>>
>>>> + <column name="datapath_version">
>>>> + Reports the OpenFlow datapath version in use. Can be empty if
>>>> + datapath version can not be determined.
>>>
>>> This still refers to OpenFlow instead of Open vSwitch.
>>
>> Had a question in my previous email: 'OpenFlow datapath' was used in
>> datapath_id description.
>> If Open vSwitch is a better name, we should consider change both. I
>> was not ignoring the comment,
>> just waiting for an answer.
>
> I didn't see that until I'd already replied to this patch, since I wouldn't have expected a v3 on outstanding questions. Regardless, I sent a reply your that question, which is that OpenFlow is correct in that spot but not here.
>
> Thanks,
>
> --Justin
>
>
More information about the dev
mailing list