[ovs-dev] [PATCH] lib/vlog: Clean up vlog usage.

[Ben Pfaff]

On Thu, Oct 23, 2014 at 01:19:07PM -0700, Jarno Rajahalme wrote:
> lib/classifier.c is also included by the tests/test-classifier.c. Make
> sure the classifier vlog module is declared only once.  This should solve a problem building OVS with --enable-shared.
> 
> lib/coverage.h and lib/stream.h included lib/vlog.h, but vlog
> interface should only be made available when a vlog module is also
> declared.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

Another approach would be to put the private header files into a
"classifier-private.h" and include that from classifier.c and
test-classifier.c.  I've found that to be a clean, simple, and
maintainable approach in other projects.