[ovs-dev] [PATCH v2] datapath-windows:Remove user mode instance from pid hash on process termination
Eitan Eliahu
eliahue at vmware.com
Fri Oct 24 17:37:17 UTC 2014
Thanks Alin!
Eitan
-----Original Message-----
From: Alin Serdean [mailto:aserdean at cloudbasesolutions.com]
Sent: Friday, October 24, 2014 10:36 AM
To: Alin Serdean; Eitan Eliahu; dev at openvswitch.org
Subject: RE: [ovs-dev] [PATCH v2] datapath-windows:Remove user mode instance from pid hash on process termination
Ignore the rebase I took the old version.
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Tested-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Alin.
-----Mesaj original-----
De la: dev [mailto:dev-bounces at openvswitch.org] În numele Alin Serdean
Trimis: Friday, October 24, 2014 8:33 PM
Către: Eitan Eliahu; dev at openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows:Remove user mode instance from pid hash on process termination
$ git apply ovs-dev-datapath-windows-Remove-user-mode-instance-from-pid-hash-on-process-termination\(1\).patch
error: patch failed: datapath-windows/ovsext/User.c:146
error: datapath-windows/ovsext/User.c: patch does not apply
Think you have to rebase Eitan.
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Tested-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Thanks,
Alin!
-----Mesaj original-----
De la: dev [mailto:dev-bounces at openvswitch.org] În numele Eitan Eliahu
Trimis: Saturday, October 25, 2014 3:47 AM
Către: dev at openvswitch.org
Subiect: [ovs-dev] [PATCH v2] datapath-windows:Remove user mode instance from pid hash on process termination
The instance should be removed from pid-hash when vswitchd.exe terminates so the driver won't access it during packet miss (causing BSOD)
Signed-off-by: Eitan Eliahu <eliahue at vmware.com>
Acked-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
Acked-by: Nithin Raju <nithin at vmware.com>
---
datapath-windows/ovsext/User.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c index 501dc12..fc27f7d 100644
--- a/datapath-windows/ovsext/User.c
+++ b/datapath-windows/ovsext/User.c
@@ -98,6 +98,7 @@ OvsCleanupPacketQueue(POVS_OPEN_INSTANCE instance)
LIST_ENTRY tmp;
PIRP irp = NULL;
+ ASSERT(instance);
InitializeListHead(&tmp);
queue = (POVS_USER_PACKET_QUEUE)instance->packetQueue;
if (queue) {
@@ -139,6 +140,11 @@ OvsCleanupPacketQueue(POVS_OPEN_INSTANCE instance)
if (queue) {
OvsFreeMemory(queue);
}
+
+ /* Remove the instance from pidHashArray */
+ OvsAcquirePidHashLock();
+ OvsDelPidInstance(gOvsSwitchContext, instance->pid);
+ OvsReleasePidHashLock();
}
NTSTATUS
--
1.9.4.msysgit.0
_______________________________________________
dev mailing list
dev at openvswitch.org
https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=yTvML8OxA42Jb6ViHe7fUXbvPVOYDPVq87w43doxtlY%3D%0A&m=q2NW4CzUt2tclwCZPuC%2FwRMaZLA4mG5kq8kmzGZJHyU%3D%0A&s=457eb4a5e3da27b25086a1e03559e9b1231c7e4d345e351dc7c98db855dd0552
_______________________________________________
dev mailing list
dev at openvswitch.org
https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=yTvML8OxA42Jb6ViHe7fUXbvPVOYDPVq87w43doxtlY%3D%0A&m=q2NW4CzUt2tclwCZPuC%2FwRMaZLA4mG5kq8kmzGZJHyU%3D%0A&s=457eb4a5e3da27b25086a1e03559e9b1231c7e4d345e351dc7c98db855dd0552
More information about the dev
mailing list