[ovs-dev] [PATCH 1/2] lib/list: Inline list functions.

Jarno Rajahalme jrajahalme at nicira.com
Thu Oct 30 16:19:07 UTC 2014


On Oct 30, 2014, at 8:43 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Oct 29, 2014 at 11:41:47AM -0700, Jarno Rajahalme wrote:
>> Subject: [ovs-dev] [PATCH 1/2] lib/list: Inline list functions.
> 
> There seems to be a new trend of writing directory names at the
> beginning of subjects, e.g. "lib/list" instead of "list".  I am not sure
> where it came from.  I've been mostly editing them out of the Hyper-V
> submissions, for example.  I think I like leaving the directory names
> out when the meaning is clear, because it leaves a little extra space
> for the description within a reasonable 70- to 75-character limit.  Do
> you have any thoughts?

I must picked up the habit from someone else… point taken :-)

> 
>> All of the list functions are really small, so inlining them should be
>> beneficial.
>> 
>> Requested-by: Ben Pfaff <blp at nicira.com>
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> Acked-by: Ben Pfaff <blp at nicira.com>

Thanks, pushed to master as "list: Inline all functions.”

  Jarno




More information about the dev mailing list