[ovs-dev] [PATCH 2/3] datapath-windws: fix locking code in OvsGetNetdevCmdHandler()

[Nithin Raju]

On Oct 30, 2014, at 8:27 AM, Eitan Eliahu <eliahue at vmware.com>
 wrote:

> Hi Nithin,
> Can you please revisit the locking sequence for the netdev handler?
> It seems that OvsGetVportDumpNext() is called with the two locks, Dispatch and Control held, (can we add a comment on it in the function header?).
> But, the Control lock is released at line 1214.

Eitan,
I have tried to follow the following sequence of acquiring locks during ioctl calls:
- Acquire the control lock
- Acquire the dispatch lock for vport calls
- Release the dispatch lock
- Release the control lock

This patch I sent out for fixes in OvsGetNetdevCmdHandler() enforces this sequence.

Are you saying that OvsGetVportDumpNext() does not adhere to this?

Thanks,
-- Nithin