[ovs-dev] [branch-2.3] ofproto: Take locks before calling classifier_count().

Ben Pfaff blp at nicira.com
Fri Oct 31 21:52:18 UTC 2014


On Thu, Oct 30, 2014 at 01:48:35PM -0700, Joe Stringer wrote:
> Commit 635e5bf55b (ofproto: Warn about excessive rule counts in OpenFlow
> tables.) introduced an access of classifier_count() without taking the
> corresponding locks first.
> 
> Found by clang.
> 
> Signed-off-by: Joe Stringer <joestringer at nicira.com>
> ---
> Maybe this is not problematic, but clang refuses to compile without a
> fix like this. The code on master has changed considerably and just
> turns off threadsafety annotations in classifier_count(). I'm not sure
> if the same fix is applicable for branch-2.3.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list