[ovs-dev] [PATCH 06/17] meta-flow: Autogenerate mf_field data structures.
Ben Pfaff
blp at nicira.com
Wed Oct 1 00:21:00 UTC 2014
On Tue, Sep 30, 2014 at 08:32:34AM +0900, YAMAMOTO Takashi wrote:
> >> On Wed, Sep 24, 2014 at 10:24:11AM +0900, YAMAMOTO Takashi wrote:
> >>> > This is a first step toward improving the abstraction of OXM and NXM in the
> >>> > tree. As an immediate improvement, this commit removes all of the
> >>> > definitions of the OXM and NXM constants from the top-level header files,
> >>> > because they are no longer used anywhere.
> >>> >
> >>> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> >>>
> >>> is it intended to drop PBB definitions?
> >>
> >> They weren't used for anything. I don't see a benefit to keeping
> >> them. If we ever implement PBB, then it's easy enough to define them.
> >
> > sounds reasonable to me, thanks.
> >
> > Acked-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
>
> btw, it's better to avoid shadowing global "line".
Thanks. I'll fix that for v2.
More information about the dev
mailing list