[ovs-dev] [PATCH] packet: Fix sparse warnings ICMPv6.

Jesse Gross jesse at nicira.com
Wed Sep 3 01:43:31 UTC 2014


On Tue, Sep 2, 2014 at 6:23 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Sep 02, 2014 at 06:00:08PM -0700, Jesse Gross wrote:
>> The system defined ICMPv6 header doesn't have sparse annotation,
>> so this adds a definition so that endianness can be checked.
>>
>> Reported-by: Alex Wang <alexw at nicira.com>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> In some cases we've avoided warnings on system types by replacing that
> type in a header in include/sparse.  Did you consider that approach
> here?

I thought about it but didn't go that direction since I think that we
might want to add more members similar to what was done for ICMP for
IPv4 (although it isn't actually needed yet). But it could go either
way.



More information about the dev mailing list