[ovs-dev] [PATCH 2/2] ofp-errors: Migrate EXT-444 errors to ONF experimenter ID.

Ben Pfaff blp at nicira.com
Thu Sep 4 19:35:33 UTC 2014


Thanks for the reviews.  I applied these patches to master.

On Thu, Sep 04, 2014 at 09:51:41AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> On Aug 21, 2014, at 10:45 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > From: Jean Tourrilhes <jt at hpl.hp.com>
> > 
> > Signed-off-by: Jean Tourrilhes <jt at hpl.hp.com>
> > [blp at nicira.com removed the definitions of these errors in OF1.1 and OF1.2]
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > lib/ofp-errors.h |   12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h
> > index 0d5bb3a..a318304 100644
> > --- a/lib/ofp-errors.h
> > +++ b/lib/ofp-errors.h
> > @@ -557,22 +557,22 @@ enum ofperr {
> >      * [Known as OFPTFFC_BAD_ARGUMENT in OF1.3.] */
> >     OFPERR_OFPBPC_BAD_VALUE,
> > 
> > -    /* HPL1.3(4443), OF1.4+(14,3).  Can't handle this many properties. */
> > +    /* ONF1.3(4443), OF1.4+(14,3).  Can't handle this many properties. */
> >     OFPERR_OFPBPC_TOO_MANY,
> > 
> > -    /* HPL1.3(4444), OF1.4+(14,4).  A property type was duplicated. */
> > +    /* ONF1.3(4444), OF1.4+(14,4).  A property type was duplicated. */
> >     OFPERR_OFPBPC_DUP_TYPE,
> > 
> > -    /* HPL1.3(4445), OF1.4+(14,5).  Unknown experimenter id specified. */
> > +    /* ONF1.3(4445), OF1.4+(14,5).  Unknown experimenter id specified. */
> >     OFPERR_OFPBPC_BAD_EXPERIMENTER,
> > 
> > -    /* HPL1.3(4446), OF1.4+(14,6).  Unknown exp_type for experimenter id. */
> > +    /* ONF1.3(4446), OF1.4+(14,6).  Unknown exp_type for experimenter id. */
> >     OFPERR_OFPBPC_BAD_EXP_TYPE,
> > 
> > -    /* HPL1.3(4447), OF1.4+(14,7).  Unknown value for experimenter id. */
> > +    /* ONF1.3(4447), OF1.4+(14,7).  Unknown value for experimenter id. */
> >     OFPERR_OFPBPC_BAD_EXP_VALUE,
> > 
> > -    /* HPL1.3(4448), OF1.4+(14,8).  Permissions error. */
> > +    /* ONF1.3(4448), OF1.4+(14,8).  Permissions error. */
> >     OFPERR_OFPBPC_EPERM,
> > 
> > /* ## -------------------- ## */
> > -- 
> > 1.7.10.4
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> 



More information about the dev mailing list