[ovs-dev] [PATCH v5 04/13] lib: Unify flags parsing and formatting.

[Jarno Rajahalme]

Thanks for the review, pushed to master,

  Jarno

On Sep 8, 2014, at 2:34 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Fri, Sep 05, 2014 at 04:05:11PM -0700, Jarno Rajahalme wrote:
>> Use the "+-" syntax more uniformly when printing masked flags, and use
>> the syntax of delimited 1-flags also for formatting fully masked TCP
>> flags.
>> 
>> The "+-" syntax only deals with masked flags, but if there are many of
>> those, the printout becomes long and confusing.  Typically there are
>> many flags only when flags are fully masked, but even then most of
>> them are zeros, so it makes sense to print the flags that are set
>> (ones) and omit the zero flags.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> I'd be inclined to just use "0" here:
> +            } else {
> +                ds_put_cstr(s, "0x000"); /* Zero flags. */
> +            }
> 

Done, relevant test cases also updated.

> Acked-by: Ben Pfaff <blp at nicira.com>