[ovs-dev] [PATCH] openvswitch.h: Fix the type of struct ovs_key_nd nd_target field.

Jarno Rajahalme jrajahalme at nicira.com
Wed Sep 10 22:09:48 UTC 2014


Thanks for the review :-)

Pushed to master,

  Jarno

On Sep 10, 2014, at 10:08 AM, Pravin Shelar <pshelar at nicira.com> wrote:

> On Tue, Sep 9, 2014 at 12:51 PM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
>> Should be the same as other IPv6 address fields.
>> 
>> Forthcoming patches produce sparse warnings without this change.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> LGTM
> Acked-by: Pravin B Shelar <pshelar at nicira.com>
> 
>> ---
>> datapath/linux/compat/include/linux/openvswitch.h |    6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/datapath/linux/compat/include/linux/openvswitch.h b/datapath/linux/compat/include/linux/openvswitch.h
>> index 6910dc4..306ea86 100644
>> --- a/datapath/linux/compat/include/linux/openvswitch.h
>> +++ b/datapath/linux/compat/include/linux/openvswitch.h
>> @@ -435,9 +435,9 @@ struct ovs_key_arp {
>> };
>> 
>> struct ovs_key_nd {
>> -       __u32 nd_target[4];
>> -       __u8  nd_sll[ETH_ALEN];
>> -       __u8  nd_tll[ETH_ALEN];
>> +       __be32 nd_target[4];
>> +       __u8   nd_sll[ETH_ALEN];
>> +       __u8   nd_tll[ETH_ALEN];
>> };
>> 
>> /**
>> --
>> 1.7.10.4
>> 
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list