[ovs-dev] [PATCH 4/4] ovs-appctl: Remove the include of vlog.h.

Alex Wang alexw at nicira.com
Wed Sep 10 22:23:39 UTC 2014


Just realized that I mistakenly sent this series (not ready) out.  Please
ignore,

I have sent the new version (3 patches instead of 4) without adding a
version number... sorry,

On Wed, Sep 10, 2014 at 12:52 PM, Alex Wang <alexw at nicira.com> wrote:

> Remove the include of vlog.h and all the related macros, since
> it is not really used.
>
> Signed-off-by: Alex Wang <alexw at nicira.com>
> ---
>  utilities/ovs-appctl.c |    7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/utilities/ovs-appctl.c b/utilities/ovs-appctl.c
> index 8249bf8..174d147 100644
> --- a/utilities/ovs-appctl.c
> +++ b/utilities/ovs-appctl.c
> @@ -31,7 +31,6 @@
>  #include "timeval.h"
>  #include "unixctl.h"
>  #include "util.h"
> -#include "vlog.h"
>
>  static void usage(void);
>  static const char *parse_command_line(int argc, char *argv[]);
> @@ -122,9 +121,6 @@ Other options:\n\
>  static const char *
>  parse_command_line(int argc, char *argv[])
>  {
> -    enum {
> -        VLOG_OPTION_ENUMS
> -    };
>      static const struct option long_options[] = {
>          {"target", required_argument, NULL, 't'},
>          {"execute", no_argument, NULL, 'e'},
> @@ -132,7 +128,6 @@ parse_command_line(int argc, char *argv[])
>          {"option", no_argument, NULL, 'o'},
>          {"version", no_argument, NULL, 'V'},
>          {"timeout", required_argument, NULL, 'T'},
> -        VLOG_LONG_OPTIONS,
>          {NULL, 0, NULL, 0},
>      };
>      char *short_options_ = long_options_to_short_options(long_options);
> @@ -184,8 +179,6 @@ parse_command_line(int argc, char *argv[])
>              ovs_print_version(0, 0);
>              exit(EXIT_SUCCESS);
>
> -        VLOG_OPTION_HANDLERS
> -
>          case '?':
>              exit(EXIT_FAILURE);
>
> --
> 1.7.9.5
>
>



More information about the dev mailing list