[ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

Samuel Ghinet sghinet at cloudbasesolutions.com
Wed Sep 10 23:15:22 UTC 2014


Hey Nithin,

AFAIK OvsCleanupOpenInstance is called by OvsCleanupDevice, which is a callback called by NDIS when an IO is pending and the file must be closed.
FreeUserDumpState is only for dump operations.

Is it possible that an IO to be pending (packet queueing) while at the same time a dump operation to be in progress, for the same file?

Sam
________________________________________
Date: Wed, 10 Sep 2014 13:17:17 -0700
From: Nithin Raju <nithin at vmware.com>
To: dev at openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during
        instance cleanup
Message-ID: <1410380237-28794-1-git-send-email-nithin at vmware.com>

Signed-off-by: Nithin Raju <nithin at vmware.com>
---
 datapath-windows/ovsext/Datapath.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c
index c145d00..d1f4b9d 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b/datapath-windows/ovsext/Datapath.c
@@ -417,6 +417,7 @@ OvsCleanupOpenInstance(PFILE_OBJECT fileObject)
     POVS_OPEN_INSTANCE instance = (POVS_OPEN_INSTANCE)fileObject->FsContext;
     ASSERT(instance);
     ASSERT(fileObject == instance->fileObject);
+    FreeUserDumpState(instance);
     OvsCleanupEvent(instance);
     OvsCleanupPacketQueue(instance);
 }
--
1.7.4.1


More information about the dev mailing list