[ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

Nithin Raju nithin at vmware.com
Fri Sep 12 20:01:56 UTC 2014


On Sep 12, 2014, at 12:46 PM, Eitan Eliahu <eliahue at vmware.com<mailto:eliahue at vmware.com>>
 wrote:

Sorry for coming late on this one.
We should free the dump state when the system calls the driver on cleanup as you did. But, the cleanup IOCTL can be (actually will be) executed from a different thread context. This means that we need to protect  dumpState.ovsMsg.

By the time IRP_MJ_CLEANUP has been called, IRP_MJ_CLOSE has already been called. So, my understanding is that there's no scope for a userspace process to be calling into the kernel. Pls. let me know if I'm missing anything.

Thanks,
-- Nithin



More information about the dev mailing list