[ovs-dev] [PATCH 1/2] datapath-windows: fix bug in NlBufCopyAtTailUninit
Nithin Raju
nithin at vmware.com
Sat Sep 13 02:45:07 UTC 2014
We should be returning value of tail before the increment
and not after.
Signed-off-by: Nithin Raju <nithin at vmware.com>
---
datapath-windows/ovsext/Netlink/NetlinkBuf.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.c b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
index ba10d83..149bfb3 100644
--- a/datapath-windows/ovsext/Netlink/NetlinkBuf.c
+++ b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
@@ -215,13 +215,11 @@ NlBufCopyAtTailUninit(PNL_BUFFER nlBuf, UINT32 len)
{
PCHAR ret = NULL;
+ ret = nlBuf->tail;
if ((NlBufCopyAtTail(nlBuf, NULL, len)) == FALSE) {
- goto done;
+ return NULL;
}
- ret = nlBuf->tail;
-
-done:
return ret;
}
--
1.7.4.1
More information about the dev
mailing list