[ovs-dev] [PATCH v2 1/3] datapath-windows/Netlink: Added support for variable length attributes in validation.

Ankur Sharma ankursharma at vmware.com
Tue Sep 16 01:14:50 UTC 2014


Added minor fix for allowing support for variable lenghth attributes in
parsing policy.

Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Nithin Raju <nithin at vmware.com>
---
 datapath-windows/ovsext/Netlink/Netlink.c | 4 +++-
 datapath-windows/ovsext/Netlink/Netlink.h | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/Netlink/Netlink.c b/datapath-windows/ovsext/Netlink/Netlink.c
index 5faf07f..0d3539c 100644
--- a/datapath-windows/ovsext/Netlink/Netlink.c
+++ b/datapath-windows/ovsext/Netlink/Netlink.c
@@ -784,7 +784,9 @@ NlAttrValidate(const PNL_ATTR nla, const PNL_POLICY policy)
     UINT32 len;
     BOOLEAN ret = FALSE;
 
-    if (policy->type == NL_A_NO_ATTR) {
+    if ((policy->type == NL_A_NO_ATTR) ||
+        (policy->type == NL_A_VAR_LEN)) {
+        /* Do not validate anything for attributes of type var length */
         ret = TRUE;
         goto done;
     }
diff --git a/datapath-windows/ovsext/Netlink/Netlink.h b/datapath-windows/ovsext/Netlink/Netlink.h
index 9964da6..0551b73 100644
--- a/datapath-windows/ovsext/Netlink/Netlink.h
+++ b/datapath-windows/ovsext/Netlink/Netlink.h
@@ -25,6 +25,7 @@
 typedef enum
 {
     NL_A_NO_ATTR = 0,
+    NL_A_VAR_LEN,
     NL_A_UNSPEC,
     NL_A_U8,
     NL_A_U16,
-- 
1.9.1




More information about the dev mailing list