[ovs-dev] [PATCH 3/5 v1] lib/netlink-socket.c: add support for nl_transact() on Windows

[Nithin Raju]

On Sep 17, 2014, at 7:02 AM, Eitan Eliahu <eliahue at vmware.com> wrote:

> 
> Hi Nithin, look good. Few comments:
> if (request_nlmsg->nlmsg_seq != reply_nlmsg->nlmsg_seq) 
> Unlink the Linux implementation the above condition should never happen. I would put just an assert there.

Eitan,
I already have an ASSERT in the if block:
+            if (request_nlmsg->nlmsg_seq != reply_nlmsg->nlmsg_seq) {
+                ovs_assert(request_nlmsg->nlmsg_seq == reply_nlmsg->nlmsg_seq);

> 
> Before accessing request_nlmsg we need to check  its size against the reply_len parameter returned from the DeviceIOControl call.

Sure. I've added checks for this in the v2.

thanks,
Nithin