[ovs-dev] [dpdk patch 2/2] dpif-netdev: Allow multi-rx-queue, multi-pmd-thread configuration.

Alex Wang alexw at nicira.com
Fri Sep 19 23:00:39 UTC 2014


Applied the patches with suggested changes

Thanks a lot for the review!

Alex Wang,

On Fri, Sep 19, 2014 at 12:14 PM, Alex Wang <alexw at nicira.com> wrote:

> > @@ -776,8 +780,10 @@ do_add_port(struct dp_netdev *dp, const char
>> *devname, const char *type,
>> >              return ENOENT;
>> >          }
>> >          /* There can only be ovs_numa_get_n_cores() pmd threads,
>> > -         * so creates a tx_q for each. */
>> > -        error = netdev_set_multiq(netdev, n_cores, NR_QUEUE);
>> > +         * so creates a txq for each. */
>> > +        error = netdev_set_multiq(netdev, n_cores,
>> > +                                  dp->n_dpdk_rxqs ? dp->n_dpdk_rxqs
>> > +                                                  : NR_QUEUE);
>> We can just initialize n_dpdk_rxqs to NR_QUEUE, so that we can avoid this
>> check.
>
>
>
> Thx, it makes sense.
>
>
>
>> Otherwise looks good.
>>
>> Acked-by: Pravin B Shelar <pshelar at nicira.com>
>>
>
>



More information about the dev mailing list