[ovs-dev] [PATCH v2 09/10] datapath-windows/Flow.c: FLOW_DEL command handler.

[Nithin Raju]

On Sep 24, 2014, at 11:58 PM, Ankur Sharma <ankursharma at vmware.com> wrote:

> Registered FLOW_DEL command handler. The same command
> handler as FLOW_ADD is good enough to handle FLOW_DEL
> case as well with minor changes for checking to action
> attribute.
> 
> Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
> Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> Acked-by: Eitan Eliahu <eliahue at vmware.com>
> ---
> datapath-windows/ovsext/Datapath.c | 5 +++++
> datapath-windows/ovsext/Flow.c     | 7 +++++--
> 2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c
> index 5008aab..5377f09 100644
> --- a/datapath-windows/ovsext/Datapath.c
> +++ b/datapath-windows/ovsext/Datapath.c
> @@ -202,6 +202,11 @@ NETLINK_CMD nlFlowFamilyCmdOps[] = {
>       .handler          = OvsFlowNlNewCmdHandler,
>       .supportedDevOp   = OVS_TRANSACTION_DEV_OP,
>       .validateDpIndex  = FALSE
> +    },
> +    { .cmd              = OVS_FLOW_CMD_DEL,
> +      .handler          = OvsFlowNlNewCmdHandler,
> +      .supportedDevOp   = OVS_TRANSACTION_DEV_OP,
> +      .validateDpIndex  = FALSE

LG. Maybe we should call the function as OvsFlowNlCmdHandler, and get rid of the 'New'.

.validateDpindex should be TRUE.

-- Nithin