[ovs-dev] [PATCH] datapath-windows: Missed packets are not queued.

Nithin Raju nithin at vmware.com
Sat Sep 27 00:22:45 UTC 2014


On Sep 24, 2014, at 2:43 AM, Sorin Vinturis <svinturis at cloudbasesolutions.com> wrote:

>    Currently, whenever there's a missed packet, the ovs driver allocates
>    memory and copies the packet even if there's no packet queue setup from
>    userspace. Then if there's no queue created, the packet is released and
>    dropped.
> 
>    The solution was to check for the existence of the userspace queue before
>    trying to allocate and add a new missed packet to the queue. If there is
>    no userspace queue created, the original packet is dropped without creating
>    a new missed packet.
> 
>    Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
>    Reported-by: Nithin Raju <nithin at vmware.com>
>    Reported-at: https://urldefense.proofpoint.com/v1/url?u=https://github.com/openvswitch/ovs-issues/issues/32&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=ubrOpIWavCMqX4l4j1LEVpTfDj%2FD5Qyn8KCoJIBGvzo%3D%0A&m=uLePLeY8RpGkczrlIXbwXC2pSoy27gSnHG94x7juZYs%3D%0A&s=ce7cccf7a6d567df25fde68fd8d2ce4a8cf443cdf8b41bf98b9f5744fc958760
> ---

Looks good to me, but for the indentation of the commit message (pointed by Ben too).

Acked-by: Nithin Raju <nithin at vmware.com>

thanks,
Nithin


More information about the dev mailing list