[ovs-dev] [PATCHv6 09/14] hash: Add 128-bit murmurhash.

Ben Pfaff blp at nicira.com
Mon Sep 29 20:30:16 UTC 2014


On Fri, Sep 26, 2014 at 09:28:13PM +1200, Joe Stringer wrote:
> Add the 128-bit murmurhash by Austin Appleby, r150 from:
> http://code.google.com/p/smhasher/source/browse/trunk/MurmurHash3.cpp
> 
> Signed-off-by: Joe Stringer <joestringer at nicira.com>
> ---
> The x64 version is approximately 2x faster than x86 in the tests I ran.

What makes these x86 and x64 versions?  Aren't they just 32-bit word
and 64-bit word versions?

The comment on getblock32() doesn't seem to match what it actually
does; it's just an array access.

I am not sure it makes sense to export hash_bytes128_x86() and
hash_bytes128_x64().  I would expect all the normal users to just call
hash_bytes128().  I see that you're trying to test both of them on all
systems, but I guess that we'll get that test coverage anyway from
normal testing on various platforms.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list