[ovs-dev] [PATCHv6 14/14] udpif: Simplify storage of key, mask in udpif_key.
Ben Pfaff
blp at nicira.com
Mon Sep 29 21:27:26 UTC 2014
On Fri, Sep 26, 2014 at 09:28:18PM +1200, Joe Stringer wrote:
> Previously we stored the netlink-formatted version of a flow key and
> mask in 'struct udpif_key'. This patch stores the original key,mask
> in the 'struct match' format, which reduces the size of a ukey from 1216
> bytes to 560. Furthermore, this reduces netlink conversions required and
> simplifies mask comparison in revalidate_ukey().
>
> Signed-off-by: Joe Stringer <joestringer at nicira.com>
> ---
> For reference, prior to this patchset the size of a udpif_key is 656, but the
> actions are not cached on master. This patch allows the entire patchset to have
> a negligible impact on the memory footprint while boosting performance. Some
> cases may even see an improvement in memory usage.
>
> v6: First post.
I understand that we can make this change if the datapath supports
UIDs, but in the case where it doesn't I don't see how we can do that,
because we have to be able to reproduce the exact key that the
datapath originally gave us. Quickly skimming the patch, I don't see
that the logic is conditional on UIDs. Is it?
More information about the dev
mailing list