[ovs-dev] [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

[Nithin Raju]

On Sep 30, 2014, at 8:03 AM, Samuel Ghinet <sghinet at cloudbasesolutions.com>
 wrote:

> If the hyper-v switch port type is external, then the function
> OvsInitConfiguredSwitchNics allocates a vport, and if allocation
> succeeds, it procedes with the initialization. However, at this
> point, virtPort may happen to be null, but check against virtPort
> was not made - this means that if virtPort was null, later on its
> fields would try to be accessed.
> 
> This patch adds a check for virtPort as well, so that the fields of
> virtPort will not be accessed if virtPort is NULL.
> 
> Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>

hi Samuel,
Thanks for the patch series. Can you pls. add some notes about validation performed. Did you make any userspace changes?

thanks,
Nithin