[ovs-dev] [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

[Eitan Eliahu]

Let's discuss it during the IRC.  Since your netdev enabled to Vport commands I think it would be a good starting point.
Thanks Alin.
Eitan

-----Original Message-----
From: Alin Serdean [mailto:aserdean at cloudbasesolutions.com] 
Sent: Tuesday, September 30, 2014 9:21 AM
To: Eitan Eliahu; Nithin Raju; Samuel Ghinet
Cc: dev at openvswitch.org; Ankur Sharma
Subject: RE: [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

Hi Eitan,

In the last IRC discussion it was settled that Nithin and Ankur will check in the netdev code. I can add patches over or suggestion.

Thanks,
Alin.

-----Mesaj original-----
De la: Eitan Eliahu [mailto:eliahue at vmware.com] 
Trimis: Tuesday, September 30, 2014 7:12 PM
Către: Alin Serdean; Nithin Raju; Samuel Ghinet
Cc: dev at openvswitch.org; Ankur Sharma
Subiect: RE: [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

Hi Alin,
I'm wondering if you could send a patch with your modified netdev code. Is this something that we could leverage?
Thanks,
Eitan

-----Original Message-----
From: Alin Serdean [mailto:aserdean at cloudbasesolutions.com] 
Sent: Tuesday, September 30, 2014 8:23 AM
To: Nithin Raju; Samuel Ghinet
Cc: dev at openvswitch.org; Eitan Eliahu; Ankur Sharma
Subject: RE: [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

Hi Nithin,

We used a modified version of netdev-windows.

Alin.

-----Mesaj original-----
De la: Nithin Raju [mailto:nithin at vmware.com] 
Trimis: Tuesday, September 30, 2014 6:09 PM
Către: Samuel Ghinet
Cc: dev at openvswitch.org; Alin Serdean; Eitan Eliahu; Ankur Sharma
Subiect: Re: [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort


On Sep 30, 2014, at 8:03 AM, Samuel Ghinet <sghinet at cloudbasesolutions.com>
 wrote:

> If the hyper-v switch port type is external, then the function 
> OvsInitConfiguredSwitchNics allocates a vport, and if allocation 
> succeeds, it procedes with the initialization. However, at this point, 
> virtPort may happen to be null, but check against virtPort was not 
> made - this means that if virtPort was null, later on its fields would 
> try to be accessed.
> 
> This patch adds a check for virtPort as well, so that the fields of 
> virtPort will not be accessed if virtPort is NULL.
> 
> Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>

hi Samuel,
Thanks for the patch series. Can you pls. add some notes about validation performed. Did you make any userspace changes?

thanks,
Nithin