[ovs-dev] [PATCH] ovs-vswitchd: Better diagnose errors in DPDK command-line options.

Daniele Di Proietto ddiproietto at vmware.com
Tue Sep 30 18:14:21 UTC 2014


Yes, I tested with and without DPDK.  It didn't cause any problem for me

Thanks,

Daniele

On 9/30/14, 11:10 AM, "Ben Pfaff" <blp at nicira.com> wrote:

>On Tue, Sep 30, 2014 at 05:11:10PM +0000, Daniele Di Proietto wrote:
>> On 9/30/14, 9:57 AM, "Ben Pfaff" <blp at nicira.com> wrote:
>> 
>> >With DPDK compiled in, when the --dpdk option was given other than as
>>the
>> >first command-line argument, ovs-vswitchd silently ignored it.  Without
>> >DPDK compiled in, when the --dpdk option was given anywhere,
>>ovs-vswitchd
>> >silently ignored it.  However, in each case any options following
>>--dpdk
>> >were not ignored, and since --dpdk is normally followed by additional
>> >DPDK-specific options, this caused even more confusing trouble.
>> >
>> >Signed-off-by: Ben Pfaff <blp at nicira.com>
>> 
>> Acked-by: Daniele Di Proietto <ddiproietto at vmware.com>
>
>I only tested this without DPDK.  I guess that you checked that it
>didn't cause any problem when built with DPDK?
>
>(I should have mentioned this in the commit message above.)
>
>Thanks,
>
>Ben.




More information about the dev mailing list