[ovs-dev] [ovsdb speedup 01/18] ovsdb: refactoring jsonrpc-server.c

[Ben Pfaff]

I think a better title for this patch would be something like
"jsonrpc-server: Split monitors into database back end and JSON-RPC
front end."

On Thu, Mar 19, 2015 at 12:08:17AM -0700, Andy Zhou wrote:
> jsonrpc-server.c has two main functions. One deals with handling the
> jsonrpc connections, the other deals with monitoring the database.
> 
> Currently, each jsonrpc connections has its own set of DB monitors.
> This can be wasteful if a number of connections shares the same
> monitors.
> 
> This patch, and a few following refactoring patches attempts to
> split the jsonrpc handling front end off the main monitoring
> functions within jsonrpc.c.
> 
> This patch changes the monitoring functions and data structures from
> 'ovsdb_jsonrpc_monitor_xxx' into 'ovsdb_monitor_xxx'
> 
> Signed-off-by: Andy Zhou <azhou at nicira.com>
> 
> ------
> The end goal of those refactoring patches is to move ovsdb_monitor
> functions into its own file.

I'd put the above comment into the commit message, as something like
"This and the following patches move the ovsdb_monitor backend functions
into their own file."

I'm happy with this patch, so I'm acking it, but I'd like to look over
the rest of the series before we start pushing patches.

Acked-by: Ben Pfaff <blp at nicira.com>