[ovs-dev] [ovsdb speedup 03/18] ovsdb: refactor ovsdb_jsonrpc_parse_monitor_request

Ben Pfaff blp at nicira.com
Wed Apr 1 16:25:25 UTC 2015


On Thu, Mar 19, 2015 at 12:08:19AM -0700, Andy Zhou wrote:
> Change ovsdb_jsonrpc_parse_monitor_request() to make
> ovsdb_monitor_table an opaque object.
> 
> Signed-off-by: Andy Zhou <azhou at nicira.com>

I'm not sure that this is the best way to check for duplicates if
ovsdb_monitor is supposed to be becoming opaque, but I'm happy to deal
with that later if necessary.

It looks like the "return" statement is indented too far here in
ovsdb_monitor_table_check_duplicates():
> +        for (i = 1; i < mt->n_columns; i++) {
> +            if (mt->columns[i].column == mt->columns[i - 1].column) {
> +                   return mt->columns[i].column->name;
> +            }

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list