[ovs-dev] [ovsdb speedup 13/18] ovsdb: rename jsonrpc_monitor_compose_table_update()

Ben Pfaff blp at nicira.com
Thu Apr 2 05:58:48 UTC 2015


On Wed, Apr 01, 2015 at 10:55:44PM -0700, Justin Pettit wrote:
> 
> > On Apr 1, 2015, at 1:24 PM, Ben Pfaff <blp at nicira.com> wrote:
> > 
> > On Thu, Mar 19, 2015 at 12:08:33AM -0700, Andy Zhou wrote:
> >> jsonrpc_monitor_compse_update() seems fit better than
> >> jsonrpc_monitor_compose_table_update(), since it composes changes
> >> from all tables.
> >> 
> >> Signed-off-by: Andy Zhou <azhou at nicira.com>
> > 
> > I think it was named after the <table-updates> object described in RFC
> > 7047, since it composes one of those objects, but this name is fine too.
> > 
> > Acked-by: Ben Pfaff <blp at nicira.com>
> 
> The first "compose" is missing an "o" in the description.

It's incomposistent!



More information about the dev mailing list