[ovs-dev] [PATCH v2] datapath-windows: Make GET_PID a separate IOCTL

Nithin Raju nithin at vmware.com
Thu Apr 2 14:43:15 UTC 2015


> On Apr 2, 2015, at 2:14 AM, Sorin Vinturis <svinturis at cloudbasesolutions.com> wrote:
> 
> Added a new IOCTL in order to retrieve the PID from the kernel datapath.
> The new method uses a direct and cleaner way, as opposed to the old way
> of using a Netlink transaction, avoiding the unnecessary overhead.
> 
> Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
> 

hi Sorin,
Thanks for addressing the review comments.

I just had one super minor comment. Looks good otherwise.

Acked-by: Nithin Raju <nithin at vmware.com>

> static NTSTATUS HandleDpTransactionCommon(
>                     POVS_USER_PARAMS_CONTEXT usrParamsCtx, UINT32 *replyLen);
> +static NTSTATUS OvsGetPidHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
> +                                    UINT32 *replyLen);

Nit: indentation of ‘replyLen’.


-- Nithin


More information about the dev mailing list