[ovs-dev] [PATCH] testsuite: ofproto-dpif: fix sockets dependencies

Flavio Leitner fbl at redhat.com
Thu Apr 2 20:33:25 UTC 2015


On Thu, 2 Apr 2015 12:58:37 -0700
Ben Pfaff <blp at nicira.com> wrote:

> On Thu, Apr 02, 2015 at 03:57:20PM -0300, Flavio Leitner wrote:
> > The ofproto-dpif creates dummies backed by sockets so depending
> > on the order of execution when bridge is reconfiguring, an active
> > socket may run first and not find the file.  That is usually not a
> > problem because it will try to reconnect one second later. However,
> > it breaks the testsuite.
> > 
> > This patch fixes the issue splitting active and passive sockets in
> > different vsctl-ctl commands that guarantees the proper ordering
> > between them.
> 
> WAIT_FOR_DUMMY_PORTS is supposed to avoid this problem, by waiting
> until the ports have connected.  Is it busted?

No, but it takes at least one extra second for the port to reconnect. If
we consider the four tests fixed by the patch, it can be 4 extra seconds
to complete the same tests, so I'd just go with the proposed patch.

fbl



More information about the dev mailing list