[ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

Ed Maste emaste at freebsd.org
Sun Apr 5 02:35:07 UTC 2015


On 4 April 2015 at 12:56, Kevin Lo <kevlo at freebsd.org> wrote:
>> Kevin, what failure mode did you observe?
>
> On FreeBSD, multicast is enabled on the interface by default, the value of
> ifr_flags could be negative if multicast is enabled.

Right, but what actually happens in this case? The sign extension bug
means it will appear as if the flags in ifr_flagshigh are set (and
perhaps those flags will be written back to the kernel, too). But I
could see certain use cases being unaffected by the bug.

To rephrase my original question perhaps: how did you discover the
bug? It doesn't matter in terms of the correctness of your fix; I'm
just curious about the fact that we didn't discover it for so long.

-Ed



More information about the dev mailing list