[ovs-dev] [PATCH] rhel: Make Fedora %files and %install section wildcards match.

[Flavio Leitner]

On Mon,  6 Apr 2015 13:56:04 -0700
Ben Pfaff <blp at nicira.com> wrote:

> Since %install puts every .ko file into /lib/modules, %files should
> make sure that all of them are packaged.

The RPM fails to build the package when there is an unpackaged file and
that is useful because it tells you are missing something. Consider
that the ovs-testcontroller is now back but the packager didn't follow
the change in upstream, so when he updates the tarball, RPM will warn
about unpackaged "/usr/bin/ovs-testcontroller" and he can decide if
that should go in a separate package, remove previous obsoletes,
enforce the correct permissions, check selinux or initscripts, or even
if it should be package/shipped or not.

So, having a more detailed %files list can result in a bit more
maintenance but it's less error prone.

Anyway, since this is a "*.ko" and I doubt we want to split them apart
or not include one, or include unintentional files, I am fine with this
patch.

Acked-by: Flavio Leitner <fbl at redhat.com>


> 
> Suggested-by: Thomas Graf <tgraf at noironetworks.com>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
> Not tested.
> 
>  rhel/openvswitch-kmod-fedora.spec.in |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/rhel/openvswitch-kmod-fedora.spec.in
> b/rhel/openvswitch-kmod-fedora.spec.in index 8f79fd2..ecea16c 100644
> --- a/rhel/openvswitch-kmod-fedora.spec.in
> +++ b/rhel/openvswitch-kmod-fedora.spec.in
> @@ -55,8 +55,7 @@ depmod %{kernel}
>  
>  %files
>  %defattr(-,root,root)
> -/lib/modules/%{kernel}/kernel/extra/openvswitch/openvswitch.ko
> -/lib/modules/%{kernel}/kernel/extra/openvswitch/vport-*.ko
> +/lib/modules/%{kernel}/kernel/extra/openvswitch/*.ko
>  
>  %changelog
>  * Wed Sep 21 2011 Kyle Mestery <kmestery at cisco.com>