[ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

[Gurucharan Shetty]

On Tue, Apr 7, 2015 at 6:01 PM, Jesse Gross <jesse at nicira.com> wrote:
> Thanks, I pushed a fix to avoid this - nothing was using the member at
> the moment, so I just replaced it with a comment.
Thank you for the quick fix!


>
> On Tue, Apr 7, 2015 at 5:31 PM, Gurucharan Shetty <shettyg at nicira.com> wrote:
>> The following series breaks windows build. Zero length arrays are not
>> supported in the middle of structures.
>>
>> source='lib/bfd.c' object='lib/bfd.lo' libtool=yes \
>> DEPDIR=.deps depmode=none /bin/sh ./build-aux/depcomp \
>> /bin/sh ./libtool --tag=CC --mode=compile build-aux/cccl
>> -DHAVE_CONFIG_H -I. -I ./include/windows -I ./datapath-windows/include
>> -IC:/pthreads-win32/Pre-built.2/include -O2 -I ./include -I ./include
>> -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
>> -Wpointer-arith -Wformat-security -Wno-format-zero-length
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -Wthread-safety -fno-strict-aliasing -g
>> -c -o lib/bfd.lo lib/bfd.c
>> libtool: compile: build-aux/cccl -DHAVE_CONFIG_H -I. -I
>> ./include/windows -I ./datapath-windows/include
>> -IC:/pthreads-win32/Pre-built.2/include -O2 -I ./include -I ./include
>> -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
>> -Wpointer-arith -Wformat-security -Wno-format-zero-length
>> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
>> -Wmissing-field-initializers -Wthread-safety -fno-strict-aliasing -g
>> -c lib/bfd.c
>> bfd.c
>> c:\openvswitch\lib\packets.h(752) : error C2233: 'options' : arrays of
>> objects containing zero-size arrays are illegal
>>
>>
>> Details here:
>> https://ci.appveyor.com/project/blp/ovs/build/1.0.140
>>
>> On Tue, Apr 7, 2015 at 4:22 PM, Pravin Shelar <pshelar at nicira.com> wrote:
>>> On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross <jesse at nicira.com> wrote:
>>>> Kernel based OVS recently added the ability to support checksums
>>>> for UDP based tunnels (Geneve and VXLAN). This adds similar support
>>>> for the userspace datapath to bring feature parity.
>>>>
>>>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>>>
>>>
>>> Thanks for adding Geneve Tunneling support.
>>>
>>> Acked-by: Pravin B Shelar <pshelar at nicira.com>
>>> _______________________________________________
>>> dev mailing list
>>> dev at openvswitch.org
>>> http://openvswitch.org/mailman/listinfo/dev