[ovs-dev] [PATCH INFO 2/2] geneve: Zero header before parsing userspace tunneling action.

[Jesse Gross]

When we parse the text representation of the Geneve action the
header is not fully initialized. Besides the obvious potential
to generate an action that the user did not actually specify, this
also causes intermittent unit test failures when an action is
read in and printed out and the result is different.

Signed-off-by: Jesse Gross <jesse at nicira.com>
---
 lib/odp-util.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/odp-util.c b/lib/odp-util.c
index 7725a09..8a81f6b 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -921,6 +921,7 @@ ovs_parse_tnl_push(const char *s, struct ovs_action_push_tnl *data)
         } else if (ovs_scan_len(s, &n, "geneve(")) {
             struct genevehdr *gnh = (struct genevehdr *) (udp + 1);
 
+            memset(gnh, 0, sizeof *gnh);
             if (ovs_scan_len(s, &n, "oam,")) {
                 gnh->oam = 1;
             }
-- 
1.9.1