[ovs-dev] [PATCH INFO 1/2] packet: Avoid array of struct with zero length member.

Jesse Gross jesse at nicira.com
Wed Apr 8 15:31:48 UTC 2015


Windows doesn't like that the Geneve header has an array of
options with each have a zero length member (the variable data).
Nothing is accessing the data now, so just replace the member with
a comment - we can use pointer arithmetic when necessary.

Reported-by: Gurucharan Shetty <shettyg at nicira.com>
Signed-off-by: Jesse Gross <jesse at nicira.com>
---
 lib/packets.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/packets.h b/lib/packets.h
index 29ea54f..b146a50 100644
--- a/lib/packets.h
+++ b/lib/packets.h
@@ -730,7 +730,7 @@ struct geneve_opt {
     uint8_t   r2:1;
     uint8_t   r1:1;
 #endif
-    uint8_t   opt_data[];
+    /* Option data */
 };
 
 struct genevehdr {
-- 
1.9.1




More information about the dev mailing list