[ovs-dev] [PATCH v2 1/1] netdev-dpdk: Reset RSS hash on transmit

Daniele Di Proietto diproiettod at vmware.com
Mon Apr 13 14:21:48 UTC 2015


Acked-by: Daniele Di Proietto <diproiettod at vmware.com>

Pravin would you mind applying the patch (if you don’t see anything wrong with it),
with the minor style fix below?

Thanks!

> @@ -1745,6 +1746,14 @@ netdev_dpdk_ring_send(struct netdev *netdev, int qid OVS_UNUSED,
>                       struct dp_packet **pkts, int cnt, bool may_steal)
> {
>     struct netdev_dpdk *dev = netdev_dpdk_cast(netdev);
> +    unsigned i;
> +
> +    /* When using 'dpdkr' and sending to a DPDK ring, we want to ensure that the
> +     * rss hash field is clear. This is because the same mbuf may be modified by
> +     * the consumer of the ring and return into the datapath without recalculating
> +     * the RSS hash. */
> +    for (i = 0; i < cnt; i++)
> +        dp_packet_set_dp_hash(pkts[i], 0);
> 

The loop body should be enclosed in braces


More information about the dev mailing list