[ovs-dev] [PATCH] perf-counters: fix non-linux build

Russell Bryant rbryant at redhat.com
Tue Apr 14 19:41:24 UTC 2015


On 04/14/2015 03:37 PM, Andy Zhou wrote:
> Commit '97a3c43515e' misses definitions for non-Linux platforms thus
> broke builds for any non-Linux platform.
> 
> Signed-off-by: Andy Zhou <azhou at nicira.com>
> ---
>  lib/perf-counter.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/lib/perf-counter.h b/lib/perf-counter.h
> index b5b72e5..c9abf72 100644
> --- a/lib/perf-counter.h
> +++ b/lib/perf-counter.h
> @@ -131,6 +131,16 @@ char *perf_counters_to_string(void);
>  
>  #define PERF_FUNCTON_COUNT_BEGIN
>  #define PERF_FUNCTON_COUNT_END
> +
> +static inline void perf_counters_init(void) {}
> +static inline void perf_counters_destroy(void) {}
> +static inline void perf_counters_clear(void) {}
> +static inline char *
> +perf_counters_to_string(void)
> +{
> +    return xstrdup("Not Supported on this platform. Only available on Linux.");
> +}
> +
>  #endif
>  
>  #endif
> 

There were a couple other functions:

uint64_t perf_counter_read(uint64_t *counter);
void perf_counter_accumulate(struct perf_counter *counter,
                             uint64_t start_count);

Is there a reason those are left out, or should they be added too?

-- 
Russell Bryant



More information about the dev mailing list