[ovs-dev] [PATCH v2 2/2] datapath-windows: Removed assert from FilterNetPnPEvent handler

Sorin Vinturis svinturis at cloudbasesolutions.com
Wed Apr 15 10:41:51 UTC 2015


Removed an inappropriate assert from the FilterNetPnPEvent routine,
OvsExtNetPnPEvent. When NDIS calls the FilterNetPnPEvent routine,
the extension is in paused state and, obviously, the switch is not
active. The switch becomes active after FilterRestart routine is
called and the restart is successfully complete.

Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
---
 datapath-windows/ovsext/Switch.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/datapath-windows/ovsext/Switch.c b/datapath-windows/ovsext/Switch.c
index 2b9a713..cfbb5a0 100644
--- a/datapath-windows/ovsext/Switch.c
+++ b/datapath-windows/ovsext/Switch.c
@@ -523,7 +523,6 @@ OvsExtNetPnPEvent(NDIS_HANDLE filterModuleContext,
             switchContext->isActivateFailed = TRUE;
         } else {
             ASSERT(switchContext->isActivated == FALSE);
-            ASSERT(switchActive == TRUE);
             if (switchContext->isActivated == FALSE && switchActive == TRUE) {
                 status = OvsActivateSwitch(switchContext);
                 OVS_LOG_TRACE("OvsExtNetPnPEvent: activated switch: %p "
-- 
1.9.0.msysgit.0



More information about the dev mailing list