[ovs-dev] [PATCH] ovs-vswitchd: Don't print supported OpenFlow versions with "-V".

Justin Pettit jpettit at nicira.com
Wed Apr 15 20:51:46 UTC 2015


> On Apr 15, 2015, at 1:41 PM, Russell Bryant <rbryant at redhat.com> wrote:
> 
> On 04/15/2015 04:30 PM, Justin Pettit wrote:
>> When "-V" was supplied to ovs-vswitchd, it was returning a max supported
>> OpenFlow version of 1.0, which is no longer true.  There are other
>> methods to determine the supported OpenFlow versions in ovs-vswitchd, so
>> remove it from the "-V" output.
>> 
>> Reported-by: Russell Bryant <rbryant at redhat.com>
>> Signed-off-by: Justin Pettit <jpettit at nicira.com>
>> ---
>> vswitchd/ovs-vswitchd.c |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/vswitchd/ovs-vswitchd.c b/vswitchd/ovs-vswitchd.c
>> index 44d44f0..a1b33da 100644
>> --- a/vswitchd/ovs-vswitchd.c
>> +++ b/vswitchd/ovs-vswitchd.c
>> @@ -180,7 +180,7 @@ parse_options(int argc, char *argv[], char **unixctl_pathp)
>>             usage();
>> 
>>         case 'V':
>> -            ovs_print_version(OFP10_VERSION, OFP10_VERSION);
>> +            ovs_print_version(0, 0);
>>             exit(EXIT_SUCCESS);
>> 
>>         case OPT_MLOCKALL:
>> 
> 
> Thanks.  :-)
> 
> Acked-by: Russell Bryant <rbryant at redhat.com>

Thanks for the report and review.  I pushed it.

--Justin





More information about the dev mailing list