[ovs-dev] [PATCH 1/3] dpctl: Fix error handling and reporting regressions.
Ben Pfaff
blp at nicira.com
Thu Apr 16 15:15:21 UTC 2015
Thanks for the review! You might have introduced these bugs but I
reviewed the changes that put them in ;-)
I applied these to master.
On Thu, Apr 16, 2015 at 12:50:55PM +0100, Daniele Di Proietto wrote:
> I’ve spend some time looking at this series, since I introduced most of
> these bugs (sorry!)
>
> With a minor comment below
>
> Acked-by: Daniele Di Proietto <diproiettod at vmware.com>
...
> Not strictly related to this patch, but I believe we could also remove the following lines,
> since the "next_destroy_args:" label is immediately below.
>
> > if (error) {
> > goto next_destroy_args;
> > }
I looked at that and decided that it was OK as-is. Not a big deal
either way.
More information about the dev
mailing list