[ovs-dev] [PATCH] bridge: Remove unused macro OFP_PORT_ACTION_WINDOW.

Ben Pfaff blp at nicira.com
Thu Apr 16 16:01:54 UTC 2015


I guess that this was missed when the corresponding feature was removed.

Reported-by: David Evans <davidjoshuaevans at gmail.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
---
 AUTHORS           |  1 +
 vswitchd/bridge.c | 10 ----------
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/AUTHORS b/AUTHORS
index d17ae7a..a2b4388 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -228,6 +228,7 @@ Chunhe Li               lichunhe at huawei.com
 Ciara Loftus            ciara.loftus at intel.com
 Daniel Badea            daniel.badea at windriver.com
 Dave Walker             DaveWalker at ubuntu.com
+David Evans             davidjoshuaevans at gmail.com
 David Palma             palma at onesource.pt
 Derek Cormier           derek.cormier at lab.ntt.co.jp
 Dhaval Badiani          dbadiani at vmware.com
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index ea7d788..4a700ae 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -217,16 +217,6 @@ static long long int stats_timer = LLONG_MIN;
 #define AA_REFRESH_INTERVAL (1000) /* In milliseconds. */
 static long long int aa_refresh_timer = LLONG_MIN;
 
-/* In some datapaths, creating and destroying OpenFlow ports can be extremely
- * expensive.  This can cause bridge_reconfigure() to take a long time during
- * which no other work can be done.  To deal with this problem, we limit port
- * adds and deletions to a window of OFP_PORT_ACTION_WINDOW milliseconds per
- * call to bridge_reconfigure().  If there is more work to do after the limit
- * is reached, 'need_reconfigure', is flagged and it's done on the next loop.
- * This allows the rest of the code to catch up on important things like
- * forwarding packets. */
-#define OFP_PORT_ACTION_WINDOW 10
-
 static void add_del_bridges(const struct ovsrec_open_vswitch *);
 static void bridge_run__(void);
 static void bridge_create(const struct ovsrec_bridge *);
-- 
2.1.3




More information about the dev mailing list