[ovs-dev] RSTP dead store

[Daniele Venturino]

I agree with Jarno, that assignment is not necessary.

Daniele

2015-04-16 22:52 GMT+02:00 Ben Pfaff <blp at nicira.com>:

> On Thu, Apr 16, 2015 at 12:54:44PM -0700, Jarno Rajahalme wrote:
> >
> > > On Apr 16, 2015, at 11:13 AM, Ben Pfaff <blp at nicira.com> wrote:
> > >
> > > Kevin Lo ran the LLVM scan-build tool and turned up a dead store in the
> > > rstp code.  Can one of you take a look and see if this looks like a
> bug?
> > >
> http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/report-6a860e.html#EndPath
> > >
> >
> > The last store to the ‘last_role’ variable is indeed not used for
> anything. I’ll send a patch to fix that.
>
> Thanks.
>