[ovs-dev] [PATCH] ofp-actions: Remove dead store in ofpacts_pull_openflow_instructions().

Jarno Rajahalme jrajahalme at nicira.com
Thu Apr 16 22:04:46 UTC 2015


Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>

> On Apr 16, 2015, at 1:48 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> Found by LLVM scan-build.
> 
> Reported-by: Kevin Lo <kevlo at FreeBSD.org>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
> lib/ofp-actions.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
> index 65fa64d..2240b86 100644
> --- a/lib/ofp-actions.c
> +++ b/lib/ofp-actions.c
> @@ -5308,8 +5308,8 @@ ofpacts_pull_openflow_instructions(struct ofpbuf *openflow,
> 
>         ofpact_pad(ofpacts);
>         start = ofpacts->size;
> -        on = ofpact_put(ofpacts, OFPACT_WRITE_ACTIONS,
> -                        offsetof(struct ofpact_nest, actions));
> +        ofpact_put(ofpacts, OFPACT_WRITE_ACTIONS,
> +                   offsetof(struct ofpact_nest, actions));
>         get_actions_from_instruction(insts[OVSINST_OFPIT11_WRITE_ACTIONS],
>                                      &actions, &actions_len);
>         error = ofpacts_decode_for_action_set(actions, actions_len,
> -- 
> 2.1.3
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list