[ovs-dev] [PATCH] netdev-bsd: Fix use of uninitialized data in netdev_bsd_rxq_recv().

Jarno Rajahalme jrajahalme at nicira.com
Thu Apr 16 22:08:17 UTC 2015


Subject should be corrected, otherwise:

Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>

> On Apr 16, 2015, at 2:19 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> When netdev_bsd_get_mtu() failed, it didn't report the error to the caller,
> so the caller couldn't work around not knowing the MTU.
> 
> Found by LLVM scan-build.
> 
> Reported-by: Kevin Lo <kevlo at FreeBSD.org>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
> lib/netdev-bsd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
> index 541e5ec..cc01470 100644
> --- a/lib/netdev-bsd.c
> +++ b/lib/netdev-bsd.c
> @@ -843,7 +843,7 @@ netdev_bsd_get_mtu(const struct netdev *netdev_, int *mtup)
>     }
>     ovs_mutex_unlock(&netdev->mutex);
> 
> -    return 0;
> +    return error;
> }
> 
> static int
> -- 
> 2.1.3
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list